Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TablePagination] Fix select variant not working #33974

Merged
merged 10 commits into from Aug 25, 2022
Merged

[TablePagination] Fix select variant not working #33974

merged 10 commits into from Aug 25, 2022

Commits on Aug 18, 2022

  1. add test cases

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    d01c299 View commit details
    Browse the repository at this point in the history

  2. apply Select variant if provided

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    26c0c7c View commit details
    Browse the repository at this point in the history

  3. do not attach variant as an attribute to select root div

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    7fa23f4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue/33894-TablePagination-select

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    9b51983 View commit details
    Browse the repository at this point in the history

  5. update test

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    e18a0eb View commit details
    Browse the repository at this point in the history

  6. test: parentNode -> parentElement

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    da058e7 View commit details
    Browse the repository at this point in the history

  7. fix visual regressions by allowing variant in inputProps

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    475a225 View commit details
    Browse the repository at this point in the history

  8. add back variant standard

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    d41ec9d View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. add comment

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    7bc5548 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/33894-TablePagination-select

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    9ef1aa8 View commit details
    Browse the repository at this point in the history