-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Specify code owners #33995
Merged
Merged
[core] Specify code owners #33995
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,195 @@ | ||
/scripts/ @michaldudak @m4theushw | ||
|
||
# Packages | ||
|
||
/packages/mui-base/ @michaldudak @mnajdova | ||
/packages/mui-icons-material/ @michaldudak @siriwatknp | ||
/packages/mui-joy/ @siriwatknp @danilo-leal | ||
/packages/mui-material/ @mnajdova @danilo-leal | ||
/packages/mui-system/ @mnajdova @siriwatknp | ||
|
||
# Components - Inputs | ||
|
||
/packages/mui-base/src/AutocompleteUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/ButtonUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/FormControlUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/InputUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/MultiSelectUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/OptionGroupUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/OptionUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/SelectUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/SliderUnstyled/ @michaldudak @mnajdova | ||
/packages/mui-base/src/SwitchUnstyled/ @michaldudak @mnajdova | ||
|
||
/packages/mui-material/src/Autocomplete/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Button/ @michaldudak @mnajdova | ||
/packages/mui-material/src/ButtonBase/ @michaldudak @mnajdova | ||
/packages/mui-material/src/ButtonGroup/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Checkbox/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Fab/ @michaldudak @mnajdova | ||
/packages/mui-material/src/FilledInput/ @michaldudak @mnajdova | ||
/packages/mui-material/src/FormControl/ @michaldudak @mnajdova | ||
/packages/mui-material/src/FormControlLabel/ @michaldudak @mnajdova | ||
/packages/mui-material/src/FormGroup/ @michaldudak @mnajdova | ||
/packages/mui-material/src/FormHelperText/ @michaldudak @mnajdova | ||
/packages/mui-material/src/FormLabel/ @michaldudak @mnajdova | ||
/packages/mui-material/src/IconButton/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Input/ @michaldudak @mnajdova | ||
/packages/mui-material/src/InputAdornment/ @michaldudak @mnajdova | ||
/packages/mui-material/src/InputBase/ @michaldudak @mnajdova | ||
/packages/mui-material/src/InputLabel/ @michaldudak @mnajdova | ||
/packages/mui-material/src/NativeSelect/ @michaldudak @mnajdova | ||
/packages/mui-material/src/OutlinedInput/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Radio/ @michaldudak @mnajdova | ||
/packages/mui-material/src/RadioGroup/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Rating/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Select/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Slider/ @michaldudak @mnajdova | ||
/packages/mui-material/src/Switch/ @michaldudak @mnajdova | ||
/packages/mui-material/src/TextField/ @michaldudak @mnajdova | ||
/packages/mui-material/src/ToggleButton/ @michaldudak @mnajdova | ||
/packages/mui-material/src/ToggleButtonGroup/ @michaldudak @mnajdova | ||
/packages/mui-material/src/useAutocomplete/ @michaldudak @mnajdova | ||
/packages/mui-material/src/useTouchRipple/ @michaldudak @mnajdova | ||
|
||
# Components - Data display | ||
|
||
/packages/mui-base/src/BadgeUnstyled/ @hbjORbj @siriwatknp @michaldudak | ||
|
||
/packages/mui-material/src/Avatar/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/AvatarGroup/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/Badge/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/Chip/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/Divider/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/Icon/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/List/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/ListItem/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/ListItemAvatar/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/ListItemButton/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/ListItemIcon/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/ListItemSecondaryAction/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/ListItemText/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/ListSubheader/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/SvgIcon/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/Table/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TableBody/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TableCell/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TableContainer/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TableFooter/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TableHead/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TablePagination/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TableRow/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/TableSortLabel/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/Tooltip/ @hbjORbj @siriwatknp | ||
/packages/mui-material/src/Typography/ @hbjORbj @siriwatknp | ||
|
||
# Components - Feedback | ||
|
||
/packages/mui-material/src/Alert/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/AlertTitle/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Backdrop/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/CircularProgress/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Dialog/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/DialogActions/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/DialogContent/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/DialogContentText/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/DialogTitle/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/LinearProgress/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Snackbar/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/SnackbarContent/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Skeleton/ @siriwatknp @hbjORbj | ||
|
||
# Components - Surfaces | ||
|
||
/packages/mui-material/src/Accordion/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/AccordionActions/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/AccordionDetails/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/AccordionSummary/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/AppBar/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Card/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/CardActionArea/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/CardActions/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/CardContent/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/CardHeader/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/CardMedia/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Paper/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Toolbar/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/useScrollTrigger/ @siriwatknp @hbjORbj | ||
|
||
# Components - Navigation | ||
|
||
/packages/mui-base/src/MenuItemUnstyled/ @hbjORbj @mnajdova @michaldudak | ||
/packages/mui-base/src/MenuUnstyled/ @hbjORbj @mnajdova @michaldudak | ||
/packages/mui-base/src/TabPanelUnstyled/ @hbjORbj @mnajdova @michaldudak | ||
/packages/mui-base/src/TabsListUnstyled/ @hbjORbj @mnajdova @michaldudak | ||
/packages/mui-base/src/TabsUnstyled/ @hbjORbj @mnajdova @michaldudak | ||
/packages/mui-base/src/TabUnstyled/ @hbjORbj @mnajdova @michaldudak | ||
/packages/mui-base/src/TablePaginationUnstyled/ @hbjORbj @mnajdova @michaldudak | ||
|
||
/packages/mui-material/src/BottomNavigation/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/BottomNavigationAction/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Breadcrumbs/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Drawer/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Link/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Menu/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/MenuItem/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/MenuList/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/MobileStepper/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Pagination/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/PaginationItem/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/SpeedDial/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/SpeedDialAction/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/SpeedDialIcon/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Step/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/StepButton/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/StepConnector/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/StepContent/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/StepIcon/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/StepLabel/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Stepper/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/SwipeableDrawer/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Tab/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/Tabs/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/TabScrollButton/ @hbjORbj @mnajdova | ||
/packages/mui-material/src/usePagination/ @hbjORbj @mnajdova | ||
|
||
# Components - Layout | ||
|
||
/packages/mui-material/src/Box/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Container/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Grid/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Hidden/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/ImageList/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/ImageListItem/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/ImageListItemBar/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Stack/ @siriwatknp @hbjORbj | ||
/packages/mui-material/src/Unstable_Grid2/ @siriwatknp @hbjORbj | ||
|
||
# Components - Utils | ||
|
||
/packages/mui-base/src/ClickAwayListener/ @mnajdova @michaldudak | ||
/packages/mui-base/src/ModalUnstyled/ @mnajdova @michaldudak | ||
/packages/mui-base/src/NoSsr/ @mnajdova @michaldudak | ||
/packages/mui-base/src/PopperUnstyled/ @mnajdova @michaldudak | ||
/packages/mui-base/src/Portal/ @mnajdova @michaldudak | ||
/packages/mui-base/src/TextareaAutosize/ @mnajdova @michaldudak | ||
/packages/mui-base/src/TrapFocus/ @mnajdova @michaldudak | ||
|
||
/packages/mui-material/src/ClickAwayListener/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Collapse/ @mnajdova @michaldudak | ||
/packages/mui-material/src/CssBaseline/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Fade/ @mnajdova @michaldudak | ||
/packages/mui-material/src/GlobalStyles/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Grow/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Modal/ @mnajdova @michaldudak | ||
/packages/mui-material/src/NoSsr/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Popover/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Popper/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Portal/ @mnajdova @michaldudak | ||
/packages/mui-material/src/ScopedCssBaseline/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Slide/ @mnajdova @michaldudak | ||
/packages/mui-material/src/TextareaAutosize/ @mnajdova @michaldudak | ||
/packages/mui-material/src/transitions/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Unstable_TrapFocus/ @mnajdova @michaldudak | ||
/packages/mui-material/src/useMediaQuery/ @mnajdova @michaldudak | ||
/packages/mui-material/src/Zoom/ @mnajdova @michaldudak |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include here the components from
mui-base
too?I would have structured this a bit differently, keeping in mind the long term goal where base would be used in both Joy UI and Material UI, by listing here the components from
/packages/mui-base/*
, and leaving everything in Joy UI and Material UI to the owners of those packages, considering the implementation there is mostly related to the design system. But as this moment this is not the case happy to start with listing both Material UI and MUI Base components.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point in the future, yes. However, as we're still at a stage where the API shape may change, I prefer to take ownership of Base as a whole so that I can keep an eye on consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it would probably mean that we need both the component owner + you for reviewing @mui/base related changes. I guess this could work 👍
BTW, I am curious, as more specific paths are assign to most of the packages/mui-material/* paths, when are we going to trigger the packages/mui-material/ owners?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong 👍 for this one and for Joy UI too. It's the best opportunity for people that are exposed to real life challenged surfaced on Material UI to transfer this knowledge to MUI Base and Joy UI as soon as possible (code changes that are delayed are a lot more painful to make happen). For me the problem I'm concerned about is not so much the API for developers but more the features, for end-users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed at the meeting on Monday, I added just the Base directories.