-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Radio][Joy] support componentsProps
as a function
#34022
Conversation
@michaldudak If the changes look good, I will apply them to all of the Joy components in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good! It's much cleaner now.
I found just some wording to correct, the rest seems good!
@@ -1,45 +1,47 @@ | |||
import { generateUtilityClass, generateUtilityClasses } from '../className'; | |||
|
|||
export interface RadioClasses { | |||
/** Styles applied to the root element. */ | |||
/** Classname applied to the root element. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** Classname applied to the root element. */ | |
/** Class name applied to the root element. */ |
- all the lines below
componentsProps
pattern (support callback) which remove the need forclasses
to style between states.Before:
After: