Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Add ownerState on the paper slot #34445

Merged
merged 3 commits into from Sep 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/mui-material/src/Popover/Popover.js
Expand Up @@ -374,6 +374,7 @@ const Popover = React.forwardRef(function Popover(inProps, ref) {
{...PaperProps}
ref={handlePaperRef}
className={clsx(classes.paper, PaperProps.className)}
ownerState={ownerState}
>
{children}
</PopoverPaper>
Expand Down
25 changes: 25 additions & 0 deletions packages/mui-material/src/Popover/Popover.test.js
Expand Up @@ -7,6 +7,7 @@ import Grow from '@mui/material/Grow';
import Modal from '@mui/material/Modal';
import Paper from '@mui/material/Paper';
import Popover, { popoverClasses as classes } from '@mui/material/Popover';
import { ThemeProvider, createTheme } from '@mui/material/styles';
import { getOffsetLeft, getOffsetTop } from './Popover';
import useForkRef from '../utils/useForkRef';

Expand Down Expand Up @@ -877,4 +878,28 @@ describe('<Popover />', () => {
expect(screen.getByTestId('transition')).not.to.have.attribute('data-timeout');
});
});

it("should not throw if ownerState is used in slot's styleOverrides", () => {
expect(() =>
render(
<ThemeProvider
theme={createTheme({
components: {
MuiPopover: {
styleOverrides: {
paper: ({ ownerState }) => ({
marginTop: ownerState.transformOrigin?.vertical === 'top' ? '4px' : 0,
}),
},
},
},
})}
>
<Popover anchorEl={document.createElement('div')} open>
<div />
</Popover>
</ThemeProvider>,
),
).not.to.throw();
});
});