Bump jscodeshift to ^0.15.2 #34680

renovate · 2022-10-09T00:29:34Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
jscodeshift	`^0.13.1` -> `^0.15.2`
@types/jscodeshift (source)	`0.11.5` -> `0.11.11`

Release Notes

facebook/jscodeshift (jscodeshift)

`v0.15.2`

Compare Source

Fixed

Process all supported extensions by default (#584, @trivikr)

`v0.15.1`

Compare Source

Changed

Upgraded to recast 0.23.3 (#564, @ashsearle)
Enable @babel/plugin-proposal-private-methods in worker (#568, @sibelius)
Upgraded Babel packages (#570, @dartess)

Fixed

Respect extensions cli option when filtering individual files (#562, @robcmills)
Fixed unit test after #562 broke them (#575, @ElonVolo)

`v0.15.0`

Compare Source

Changed

Upgraded to recast 0.23.1 (#544, @ryanrhee)
Make @babel/preset-env optional (#480, @SimenB)

Fixed

Force LF line ending in bin/jscodeshift.sh (#555, @jakeboone02)
Use transform's exported parser in testUitls (#528, @CrispyBacon12)
Ensure jscodeshift doesn't load Babel config file (#460, @raon0211)

`v0.14.0`

Compare Source

Added

Added a defineSnapshotTestFromFixture test util (#471, @shriuken)
Added renameTo filters for Babel 6+ node types (#412 and #504, @elonvolo and @henryqdineen)
Added childNodesOfType to JSX traversal methods (#415, @j13huang)

Changed

Bumped dependency versions
Allow arguments in --help to be listed in an order other than alphabetically, so they can instead be grouped thematically (#507, @elonvolo)
Allow the j shortcut in test utils (#515, @no23reason)

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

mui-bot · 2022-10-09T00:33:01Z

Netlify deploy preview

https://deploy-preview-34680--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 92b8a2a

mnajdova

The output looks wrong, it generates duplicate brackets. cc @siriwatknp

siriwatknp · 2024-04-10T06:07:23Z

I think we should merge this dep update for v6. I assume that most projects have code formatting tools like prettier. I am updating the tests.

renovate · 2024-04-10T07:05:59Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

Janpot · 2024-04-10T09:30:35Z

How about in mui-codemod we just run prettier on a file ourselves after the jscodeshift, if we detect a prettier setup?

siriwatknp · 2024-04-11T07:09:10Z

How about in mui-codemod we just run prettier on a file ourselves after the jscodeshift, if we detect a prettier setup?

~~I am thinking about detecting double ((*)) and removing it, so that I don't have to change all of the expected tests.~~ Let me try the prettier.

…te/jscodeshift-0.x

…erial-ui into renovate/jscodeshift-0.x

…te/jscodeshift-0.x

Janpot · 2024-04-11T12:24:07Z

packages/mui-codemod/codemod.js

@@ -162,6 +162,11 @@ function run(argv) {

  runJscodeshiftTransform(codemod, files, flags, argv._);
  runPostcssTransform(codemod, files);
+  if (!flags.skipPrettier) {
+    childProcess.spawnSync('prettier', ['--write', `prettier --write $(git diff --name-only)`], {


Feels a bit heavy to spawn an extra process, wouldn't it be possible as a jscodeshift transformer?

import * as prettier from 'prettier'; export default async function transformer(file) { const prettierConfig = await prettier.resolveConfig(file.path); return prettier.format(file.source, prettierConfig); }

Almost feels like those APIs were made for each other 😄

We need to add prettier as a dependency, so using npx will be a bit slower, right?

Adding this requires a lot of changes to the expected files. I try to avoid it.

there could be a one time cost in some cases, looks like prettier total install size is about 50% of jscodeshift total install size (total size = package + dependencies). I'm not sure npx install time is something we should optimize for here, ideally this will be run at most once ever over the lifetime of a project.

I suppose you can still make it optional with a skipPrettier flag

ideally this will be run at most once ever over the lifetime of a project

If the codemod release a new version, isn't another installation is required?

I suppose you can still make it optional with a skipPrettier flag

Yes, it can be skipped.

I tried timing the installation of jscodeshift alone and also jscodeshift and prettier together and the difference seems to be insignificant (<10ms)

siriwatknp · 2024-04-11T13:19:00Z

packages/mui-codemod/codemod.js

+  } else if (!flags.skipPrettier) {
+    try {
+      childProcess.execSync('prettier --write $(git diff --name-only)', {
+        stdio: 'inherit',
+      });
+    } catch (error) {
+      // silentyly ignore errors
+    }


Tested, with the CSB build, it works fine. @Janpot what do you think?

Personally I don't think we should do it this way. I suppose the idea of ignoring all errors is to ignore when prettier is not installed. But this will also silence any other useful error. For instance, in large projects this will potentially generate a large amount of file names, which can result in failures in the shell as there are limits to the command length. We've ran into this ourselves with code infra with our prettier command and this is the reason why we now use a tool that runs prettier programmatically.

I think we should run prettier programmatically on every file if:

there is a straightforward way to run it e.g. through a jscodeshift transformer

there is a straightforward way to turn it off with a flag

there is a straightforward way to turn it off when no prettier config exists in the project

If any of these 3 conditions is impossible, I'd consider not adding prettier formatting at all.

which can result in failures in the shell as there are limits to the command length

I think it's an edge case because the prettier only runs on changed files. I used to run codemod on several large projects (backstage is one of them) but I've never found a case where file changes go beyond hundreds before.

Anyway, in case there is an error, --skip-prettier can be used.

What we could do is to not add prettier at first and see the feedback. I will remove it for now.

I ended up here after running the deprecations codemod in our docs. I had some files present the double parens issue. In my case, it was easy to bypass running prettier manually. It wasn't that bad. I wouldn't complain if prettier was ran automatically, maybe as an opt-in.

We should at least add a warning for this in the codemod readme.

renovate bot added the dependencies Update of dependencies label Oct 9, 2022

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 10, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 956dc0c to a0f02a0 Compare October 10, 2022 18:06

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Oct 10, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from a0f02a0 to 7078000 Compare October 14, 2022 20:44

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 14, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 7078000 to 17a2955 Compare October 19, 2022 01:08

mnajdova reviewed Oct 26, 2022

View reviewed changes

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 17a2955 to 4f0dfcf Compare October 27, 2022 13:58

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 4f0dfcf to 5d62c80 Compare October 31, 2022 10:10

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch 3 times, most recently from 3b4351e to f424e73 Compare November 7, 2022 17:23

renovate bot force-pushed the renovate/jscodeshift-0.x branch 2 times, most recently from 125097f to 876f52a Compare November 9, 2022 19:07

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 9, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 876f52a to dbc323f Compare November 9, 2022 23:42

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 9, 2022

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from dbc323f to 1d6295f Compare December 1, 2022 15:17

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 1d6295f to 8c31857 Compare December 6, 2022 11:04

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 6, 2022

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 8c31857 to 4c30610 Compare December 6, 2022 17:13

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 6, 2022

michaldudak mentioned this pull request Dec 8, 2022

Extra parens inserted around JSX after attributes are added facebook/jscodeshift#534

Open

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 28, 2024

renovate bot force-pushed the renovate/jscodeshift-0.x branch from 183fd28 to c2febc9 Compare March 29, 2024 06:09

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 29, 2024

Bump jscodeshift to ^0.15.2

865372d

renovate bot force-pushed the renovate/jscodeshift-0.x branch from c2febc9 to 865372d Compare April 3, 2024 17:29

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 3, 2024

fix all expected tests

a64976c

siriwatknp approved these changes Apr 10, 2024

View reviewed changes

siriwatknp added 4 commits April 11, 2024 14:09

Merge branch 'next' of https://github.com/mui/material-ui into renova…

e91f8ed

…te/jscodeshift-0.x

run prettier after transformation

cfa055e

Merge branch 'renovate/jscodeshift-0.x' of https://github.com/mui/mat…

43370da

…erial-ui into renovate/jscodeshift-0.x

Merge branch 'next' of https://github.com/mui/material-ui into renova…

7f7d2c2

…te/jscodeshift-0.x

Janpot reviewed Apr 11, 2024

View reviewed changes

siriwatknp added 4 commits April 11, 2024 19:36

run prettier after jscodeshift

7050c34

fix lint

6c66615

use execSync

802c94e

add try catch

e51daeb

siriwatknp reviewed Apr 11, 2024

View reviewed changes

siriwatknp added 2 commits April 11, 2024 20:24

fix lint

5e2d461

revert prettier

92b8a2a

siriwatknp requested a review from Janpot April 11, 2024 14:49

Janpot approved these changes Apr 11, 2024

View reviewed changes

siriwatknp merged commit 17eea99 into next Apr 11, 2024
19 checks passed

siriwatknp deleted the renovate/jscodeshift-0.x branch April 11, 2024 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump jscodeshift to ^0.15.2 #34680

Bump jscodeshift to ^0.15.2 #34680

renovate bot commented Oct 9, 2022 •

edited by siriwatknp

mui-bot commented Oct 9, 2022 •

edited

mnajdova left a comment

siriwatknp commented Apr 10, 2024

renovate bot commented Apr 10, 2024

Janpot commented Apr 10, 2024

siriwatknp commented Apr 11, 2024 •

edited

Janpot Apr 11, 2024

siriwatknp Apr 11, 2024

Janpot Apr 11, 2024 •

edited

siriwatknp Apr 11, 2024

Janpot Apr 11, 2024

siriwatknp Apr 11, 2024 •

edited

Janpot Apr 11, 2024

siriwatknp Apr 11, 2024

siriwatknp Apr 11, 2024

DiegoAndai May 8, 2024

DiegoAndai May 8, 2024

Bump jscodeshift to ^0.15.2 #34680

Bump jscodeshift to ^0.15.2 #34680

Conversation

renovate bot commented Oct 9, 2022 • edited by siriwatknp

Release Notes

Fixed

Changed

Fixed

Changed

Fixed

Added

Changed

Configuration

mui-bot commented Oct 9, 2022 • edited

Netlify deploy preview

Bundle size report

mnajdova left a comment

Choose a reason for hiding this comment

siriwatknp commented Apr 10, 2024

renovate bot commented Apr 10, 2024

Edited/Blocked Notification

Janpot commented Apr 10, 2024

siriwatknp commented Apr 11, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Janpot Apr 11, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siriwatknp Apr 11, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

renovate bot commented Oct 9, 2022 •

edited by siriwatknp

mui-bot commented Oct 9, 2022 •

edited

siriwatknp commented Apr 11, 2024 •

edited

Janpot Apr 11, 2024 •

edited

siriwatknp Apr 11, 2024 •

edited