[website] Replace initial value with theme white #34822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
docs
|
1 task
siriwatknp
changed the title
oliviertassinari
added
bug 🐛
|
Nice 👌 |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #33545 (comment).
Root cause
I guess this is a bug on Safari and Firefox because the
color: initialshould use the systemCanvasTextcolor but somehow it returns black (even though thecolor-scheme: dark).Reference: https://www.w3.org/TR/css-color-4/#changes-from-20191105
Fix
Force color to
theme.common.whiteto make the color consistent across browsers.I will merge the PR once the CIs are green and make a hotfix deployment.