-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooltip] Save a few bytes #34853
[Tooltip] Save a few bytes #34853
Conversation
|
What's the rationale behind using |
@michaldudak The rationale was that it's easier to work with, meaning when you write a new test, it's easier to access a global variable than to go up to the @eps1lon Does it match with the value you envision? I can revert the changes in the tests if we are not comfortable with them. |
|
👍 I'm fine with this change. My only concern is that it doesn't really fall into the "Save a few bytes" label. Could we make it a separate PR? |
This is a follow-up on #34289, I'm giving up on the idea of having title !== '' && title !== node an invalid value. We can be less opinionated about the best practice. Instead:
screen
as much as possible that Sebastian started. It's supposed to be simpler to work with.