Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Migrate career page to use CSS theme variables #34908

Merged
merged 7 commits into from
Oct 31, 2022
Merged

[website] Migrate career page to use CSS theme variables #34908

merged 7 commits into from
Oct 31, 2022

Conversation

the-mgi
Copy link
Contributor

@the-mgi the-mgi commented Oct 27, 2022 •
edited by mnajdova

Part of #34880 - Career page

@mui-bot
Copy link

mui-bot commented Oct 27, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-34908--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 79616b5

@the-mgi the-mgi mentioned this pull request Oct 27, 2022
Closed
10 tasks
@the-mgi
Copy link
Contributor Author

the-mgi commented Oct 27, 2022

this PR is in draft right now, have a question over here #34880

@the-mgi the-mgi marked this pull request as ready for review October 27, 2022 15:57
@the-mgi the-mgi marked this pull request as draft October 27, 2022 15:59
@siriwatknp siriwatknp changed the title docs/career page use CSS theme variables [website] Migrate career page to use CSS theme variables Oct 28, 2022
@siriwatknp siriwatknp added the website Pages that are not documentation-related, marketing-focused. label Oct 28, 2022
@the-mgi the-mgi marked this pull request as ready for review October 28, 2022 07:08
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
siriwatknp
siriwatknp approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work! thanks for your contribution.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
@the-mgi
Copy link
Contributor Author

the-mgi commented Oct 31, 2022 •
edited

Welcome @siriwatknp. and thanks to you for helping out.

@mnajdova
Copy link
Member

@the-mgi great work. One note, please don't use fixes #PR_NUMBER unless you actually want the issue to be closed :) I've replaced the "Fixes" with "Part of" :)

@siriwatknp siriwatknp merged commit f799d72 into mui:master Oct 31, 2022
@the-mgi
Copy link
Contributor Author

the-mgi commented Oct 31, 2022

@the-mgi great work. One note, please don't use fixes #PR_NUMBER unless you actually want the issue to be closed :) I've replaced the "Fixes" with "Part of" :)

okay, got it. thanks 🙌

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@the-mgi
[website] Migrate career page to use CSS theme variables (mui#34908)
71112f7
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@the-mgi
[website] Migrate career page to use CSS theme variables (mui#34908)
074d7f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@the-mgi @mui-bot @mnajdova @siriwatknp