Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Use span for icon image #34914

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Oct 28, 2022

Found this issue while migrating pages to CSS theme variables. The Box defaults to div which can not be used inside a Typography.

@siriwatknp siriwatknp added the website Pages that are not documentation-related, marketing-focused. label Oct 28, 2022
@mui-bot
Copy link

mui-bot commented Oct 28, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34914--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against d2f9e71

@siriwatknp siriwatknp merged commit 7ec53f0 into mui:master Oct 28, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 29, 2022

Nice, I didn't see it when I worked a bit on this logic: b164c9d.

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants