New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Migrate Pricing page to use CSS theme variables #34917
[website] Migrate Pricing page to use CSS theme variables #34917
Conversation
|
Nice, this solves this bug: https://deploy-preview-33545--material-ui.netlify.app/pricing/ (bug introduced in #33545) @siriwatknp I think that it could be valuable to have the e2e tests that we run on the docs to take screenshots and push them to Argos CI. We have increasingly more room for visual regressions beyond the demos. One way to pull it off, we could build the docs in CircleCI, and run the e2e tests on CircleCI rather than on Netlify to take the screenshots, and have a later stage that pushes to Argos CI. |
Added to the docs infra idea. I think the other way of doing the visual regression is to extract our docs into smaller pieces and run the visual regression, e.g. having docs component in the storybook using chromatic to run the visual regression so that the CIs does not slow down the core products. |
@siriwatknp Thanks, maybe a GitHub issue would be enough in our case. I'm not sure when Notion or GitHub is best. In any case, it's borderline between
It's doable with the existing infrastructure but, I would imagine that it's:
|
One of the tasks from #34880