Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Migrate Pricing page to use CSS theme variables #34917

Merged

Conversation

trizotti
Copy link
Contributor

One of the tasks from #34880

@mui-bot
Copy link

mui-bot commented Oct 28, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34917--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 577470a

@zannager zannager added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. website Pages that are not documentation-related, marketing-focused. labels Oct 28, 2022
@trizotti trizotti marked this pull request as ready for review October 31, 2022 12:28
@siriwatknp siriwatknp merged commit 5c7266a into mui:master Nov 1, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 4, 2022

Nice, this solves this bug:

Screenshot 2022-11-04 at 14 38 56

https://deploy-preview-33545--material-ui.netlify.app/pricing/ (bug introduced in #33545)

@siriwatknp I think that it could be valuable to have the e2e tests that we run on the docs to take screenshots and push them to Argos CI. We have increasingly more room for visual regressions beyond the demos.

One way to pull it off, we could build the docs in CircleCI, and run the e2e tests on CircleCI rather than on Netlify to take the screenshots, and have a later stage that pushes to Argos CI.

@siriwatknp
Copy link
Member

@siriwatknp I think that it could be valuable to have the e2e tests that we run on the docs to take screenshots and push them to Argos CI. We have increasingly more room for visual regressions beyond the demos.

One way to pull it off, we could build the docs in CircleCI, and run the e2e tests on CircleCI rather than on Netlify to take the screenshots, and have a later stage that pushes to Argos CI.

Added to the docs infra idea. I think the other way of doing the visual regression is to extract our docs into smaller pieces and run the visual regression, e.g. having docs component in the storybook using chromatic to run the visual regression so that the CIs does not slow down the core products.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 7, 2022

@siriwatknp Thanks, maybe a GitHub issue would be enough in our case. I'm not sure when Notion or GitHub is best. In any case, it's borderline between website and docs-infra

is to extract our docs into smaller pieces and run the visual regression

It's doable with the existing infrastructure but, I would imagine that it's:

  1. more incremental work. We would have to handpick which components to test when we could take a fullpage screenshot
  2. less reliable. In our case, the issue was from globals side effects of CSS/React context inheritance. We could have more trust in an e2e screenshot.

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants