[core] A couple of simply fixes from #34870 #34953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,14 +155,14 @@ module.exports = async function demoLoader() { | |||
| this.addDependency(moduleFilepath); | |||
| demos[demoName] = { | |||
| module: moduleID, | |||
| raw: await fs.readFile(moduleFilepath, { encoding: 'utf-8' }), | |||
| raw: await fs.readFile(moduleFilepath, { encoding: 'utf8' }), | |||
There was a problem hiding this comment.
It's an alias, but the default is the one used here https://github.com/nodejs/node/blob/2364ed7d669bd569f8a70147c177a132ef5a7100/lib/buffer.js#L688.
Comment on lines
-225
to
-230
|
|
||
| export const docs = ${JSON.stringify(docs, null, 2)}; | ||
| export const demos = ${JSON.stringify(demos, null, 2)}; | ||
| export const demoComponents = {${Array.from(demoModuleIDs) | ||
| .map((moduleID) => { | ||
| return `${JSON.stringify(moduleID)}: ${moduleIDToJSIdentifier(moduleID)},`; |
There was a problem hiding this comment.
The extra lines make a console.log of the output messy.
|
oliviertassinari
force-pushed
the
extract-simple-fixes-from-34870
branch
from
ecd2b72
to
bf1b6a1
Compare
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #34870 as they are improvements on their own.