[core] Create the docs theme once #34954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
docs-theme-once
branch
from
5e4b4ea
to
b85ea74
Compare
| 'Ubuntu Mono', | ||
| 'monospace', | ||
| ].join(','), | ||
| fontFamilyCode: ['Consolas', 'Monaco', 'Andale Mono', 'Ubuntu Mono', 'monospace'].join(','), |
There was a problem hiding this comment.
Sync with docs/public/static/styles/prism-okaidia.css font family.
|
|
@bharatkashyap Shall we do this in Toolpad as well? @oliviertassinari (off-topic), we greatly simplified the theme switching logic in Toolpad using our |
|
@Janpot I think for Jun to explore, we have a bug right now: #33545 (comment). |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to create the same theme over and over again between each
BrandingProviderinstance. In the Joy UI pages, we mount this component a lot of times which can lead to a lot of console.log when you try to debug it.Off-topic it seems that there are way too many ThemeProvider used in the pages, but it's a different problem, so I'm not looking into it. I think that what we need is:
_app)