Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix missing emotion prefixes #34958

Merged
merged 1 commit into from Oct 31, 2022
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 30, 2022

This fixes a regression introduced in #33545. I have notice it when I was looking at the screenshot of #34859, it looked wrong, the header background is meant to be blurred:

Screenshot 2022-10-30 at 21 37 38

Why does this happen? Because of https://github.com/emotion-js/emotion/blob/d8a13bcae81812d3dff643bcf446709f965f0909/packages/cache/src/index.js#L84. My end goal is to get a nice reading experience for the blog on iOS.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse labels Oct 30, 2022
@mui-bot
Copy link

mui-bot commented Oct 30, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34958--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 5db7f19

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Found this too! Thanks for the fix.

@mnajdova mnajdova merged commit ff26e71 into mui:master Oct 31, 2022
@oliviertassinari oliviertassinari deleted the fix-prefixer branch October 31, 2022 10:31
@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Nov 21, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants