Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add gap property documentation for Flexbox #35104

Closed
wants to merge 2 commits into from
Closed

[docs] Add gap property documentation for Flexbox #35104

wants to merge 2 commits into from

Conversation

yousoumar
Copy link

@yousoumar yousoumar commented Nov 12, 2022

There is no documentation for gap property in Flexbox page. gap is an important property that works for Grid and Flexbox in the same way. This PR adds the missing documentation.

@mui-bot
Copy link

mui-bot commented Nov 12, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35104--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 05b9b96

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 12, 2022

There is a mismatch between what we say in https://mui.com/material-ui/getting-started/supported-platforms/#browser and https://caniuse.com/flexbox-gap. The mismatch is with Safari. We support v12.5 while flex gap is only available since v14.5 Considering:

Screenshot 2022-11-12 at 14 02 10

https://caniuse.com/flexbox-gap

and

Screenshot 2022-11-12 at 14 05 38

https://gs.statcounter.com/ios-version-market-share/mobile/worldwide/#quarterly-201903-202204

It seems that it's indeed time that we start using it. I have added this breaking change idea to #30660.

Screenshot 2022-11-12 at 14 11 02


On a different note, since our last major was over a year ago. I think that it could even make sense to have a small v6 BCs cycle, something easy to upgrade to (not saying that we should do it, but it doesn't sound unreasonable)

@yousoumar
Copy link
Author

Hi @oliviertassinari! Thanks for the insights! I didn't know about this support thing.

@yousoumar yousoumar closed this by deleting the head repository Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants