Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Generate vars in
extendTheme
#35739[core] Generate vars in
extendTheme
#35739Changes from 6 commits
973af92
0c6ad95
1e3dd19
315574e
3e5eee9
7e1ff8b
707b7a4
1c17730
cc2f375
ec2c1af
fbc5c8d
de86915
ae73183
5fc8f01
9521a0e
edc897e
aad2c60
8d76b1f
fd85ec6
b6f92c9
7720593
05c1d81
bef9873
576a331
76e434b
0138dfc
9a01043
176dbcf
56fce0b
0de9228
ab2baac
48b379a
5091fcd
62c77e5
8dd6c5d
7f1e4a1
5f7cebb
7af8584
570be4e
40a136c
1060372
bad09ac
212e562
7231468
afa507c
9a155a8
a88d82d
8239fb4
4853012
d1ec41d
e0b812a
537bb48
4673d86
84f48cf
63824fb
2579b29
9078414
ce8e021
14b3afa
8ddf9fd
1cb7776
1577eab
f7061a1
ff7fe66
329aa26
64b1006
76e1011
a5b48ca
c602938
e442707
7f37346
70b4fc1
65527cf
06e89e5
b6bdfe1
34ced86
753ea85
5c657de
d93ab8c
91c85d9
64094b2
e27cb0e
27a6f5b
f443527
98b8ad3
478eaaf
6cc38d9
d930896
d12e77b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG, I love this! ❤️ 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if
extendTheme()
should not resolve the palette yet.My initial intention is that
extendTheme()
should return sets of colors for your application but it should not decide what the current color scheme is. That logic will be handled byCssVarsProvider
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same default implementation as in
defaultTheme
.