Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Replace SliderUnstyled with useSlider hook #35770

Merged
merged 13 commits into from Jan 12, 2023
Merged

[Slider] Replace SliderUnstyled with useSlider hook #35770

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
aa0c6b2
replace SliderUnstyled with useSlider hook
ZeeshanTamboli Jan 8, 2023
a41b147
remove ony constraint in test
ZeeshanTamboli Jan 8, 2023
6195b05
use SliderValueLabelProps from Material-UI Slider
ZeeshanTamboli Jan 8, 2023
9e2f66f
yarn docs:api
ZeeshanTamboli Jan 8, 2023
9ad9b37
make children type optional
ZeeshanTamboli Jan 9, 2023
130239f
yarn docs:typescript:formatted
ZeeshanTamboli Jan 9, 2023
02650e5
fix types
ZeeshanTamboli Jan 9, 2023
376b41d
yarn docs:typescript:formatted
ZeeshanTamboli Jan 9, 2023
af8f3c1
Update packages/mui-material/src/Slider/Slider.js
ZeeshanTamboli Jan 9, 2023
f250330
address PR comments
ZeeshanTamboli Jan 9, 2023
f7176e6
make children prop required in SlideValueLabelProps
ZeeshanTamboli Jan 9, 2023
ecb0534
Merge branch 'master' into slider/replace-SliderUnstyled-with-useSlid…
ZeeshanTamboli Jan 10, 2023
018c2a9
Merge branch 'master' into slider/replace-SliderUnstyled-with-useSlid…
ZeeshanTamboli Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/pages/material-ui/api/slider.json
View file
Open in desktop
Expand Up @@ -137,7 +137,7 @@
"spread": true,
"forwardsRefTo": "HTMLSpanElement",
"filename": "/packages/mui-material/src/Slider/Slider.js",
"inheritance": { "component": "SliderUnstyled", "pathname": "/base/api/slider-unstyled/" },
"inheritance": null,
"demos": "<ul><li><a href=\"/material-ui/react-slider/\">Slider</a></li></ul>",
"cssComponent": false
}
3 changes: 1 addition & 2 deletions packages/mui-material/src/Slider/Slider.d.ts
View file
Open in desktop
Expand Up @@ -84,7 +84,7 @@ export type SliderTypeMap<
defaultComponent: D;
}>;

export { SliderValueLabelProps } from '@mui/base/SliderUnstyled';
export { SliderValueLabelProps };

type SliderRootProps = NonNullable<SliderTypeMap['props']['componentsProps']>['root'];
type SliderMarkProps = NonNullable<SliderTypeMap['props']['componentsProps']>['mark'];
Expand All @@ -110,7 +110,6 @@ export declare const SliderValueLabel: React.FC<SliderValueLabelProps>;
* API:
*
* - [Slider API](https://mui.com/material-ui/api/slider/)
* - inherits [SliderUnstyled API](https://mui.com/base/api/slider-unstyled/)
*/
declare const Slider: ExtendSliderUnstyled<SliderTypeMap>;

Expand Down