Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Remove unnecessary data-focusvisible attribute #36091

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Feb 7, 2023

Resolves comment #35770 (comment). Even I don't see it being used anywhere.

It's not documented, so I guess it's not a breaking change.

@ZeeshanTamboli ZeeshanTamboli added component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material package: base-ui Specific to @mui/base enhancement This is not a bug, nor a new feature labels Feb 7, 2023
@mui-bot
Copy link

mui-bot commented Feb 7, 2023

Netlify deploy preview

https://deploy-preview-36091--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 6c3d491

@michaldudak
Copy link
Member

It looks OK to me, but let's wait for @mnajdova's opinion.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Using the focusVisible class name in Material UI instead makes a lot of sense

@ZeeshanTamboli ZeeshanTamboli merged commit 464fb9e into mui:master Feb 21, 2023
@ZeeshanTamboli ZeeshanTamboli deleted the slider-remove-redundant-data-focusvisible-attribute branch February 21, 2023 12:39
@oliviertassinari oliviertassinari added breaking change bug 🐛 Something doesn't work and removed package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels Feb 21, 2023
siriwatknp pushed a commit to mnajdova/material-ui that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants