[docs][joy] Clarify when CssVarsProvider is required
#36410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
docs
Netlify deploy preview
Bundle size report |
mnajdova
commented
Mar 3, 2023
| @@ -8,15 +8,10 @@ The following code snippet demonstrates a simple app that uses the Joy UI [Butto | |||
|
|
|||
| ```jsx | |||
| import * as React from 'react'; | |||
| import { CssVarsProvider } from '@mui/joy/styles'; | |||
| import Button from '@mui/joy/Button'; | |||
|
|
|||
| export default function MyApp() { | |||
There was a problem hiding this comment.
@samuelsycamore after we do the release on Monday, we should unfreeze the sandbox below and be able to remove the CssVarsProvider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #35739, the using of CssVarsProvider in Joy UI apps is not required, unless it is used together with the Material UI icons - this is when we need to provide context theme change for the icon components. We may be able to solve this in the future, by updating the icon's styles in Material UI.