[docs] Adding tree shaking guide for SWC compiler #36456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nereuseng <nereuseng@gmail.com>
Signed-off-by: nereuseng <nereuseng@gmail.com>
Signed-off-by: nereuseng <nereuseng@gmail.com>
Netlify deploy previewBundle size report |
nereuseng
commented
Mar 8, 2023
docs/data/material/guides/minimizing-bundle-size/minimizing-bundle-size.md
Outdated
Show resolved
Hide resolved
…ndle-size.md Signed-off-by: nereuseng <nereuseng@gmail.com>
|
|
||
| `yarn add -D @swc/plugin-transform-imports` | ||
|
|
||
| Modify your .swcrc or Webpack configuration: |
There was a problem hiding this comment.
Below we are showing the config for Webpack, so mentioning .swcrc here may confuse devs. It would be better to show a separate config for .swcrc.
Suggested change
| Modify your .swcrc or Webpack configuration: | |
| Modify your webpack configuration as shown below: |
|
|
||
| This option pretty much similar to the option two, except for the developer who is using [SWC Compiler](https://swc.rs/). Use this [plugin](https://github.com/swc-project/plugins/blob/main/packages/transform-imports/README.md): | ||
|
|
||
| `yarn add -D @swc/plugin-transform-imports` |
There was a problem hiding this comment.
Would we also need @swc/core and swc-loader dependencies?
Comment on lines
+225
to
+226
| test: /\.tsx?$/, | ||
| use: [ |
There was a problem hiding this comment.
Should we exclude node_modules?
Suggested change
| test: /\.tsx?$/, | |
| use: [ | |
| test: /\.tsx?$/, | |
| exclude: /(node_modules)/, | |
| use: [ |
| module: { | ||
| rules: [ | ||
| ...{ | ||
| test: /\.tsx?$/, |
There was a problem hiding this comment.
Include Javascript files as well:
Suggested change
| test: /\.tsx?$/, | |
| test: /\.(tsx?|jsx?)$/, |
|
Since the PR is inactive from a long time, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Basically inspired by this PR: #35457.