Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove shouldSkipGeneratingVar usage #36581

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

siriwatknp
Copy link
Member

Since #35739, shouldSkipGeneratingVar has been moved to extendTheme. For using Joy and Material UI, there is no need to merge those functions.

Remove them in the guide to make it a bit simpler.

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Mar 20, 2023
@siriwatknp siriwatknp requested a review from hbjORbj March 20, 2023 09:00
@mui-bot
Copy link

mui-bot commented Mar 20, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e22690e

Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Looks good.

@hbjORbj
Copy link
Member

hbjORbj commented Mar 20, 2023

Did you update the Codesandboxes? I don't have a comment other than this.

@siriwatknp siriwatknp merged commit 6c4d34f into mui:master Mar 21, 2023
@siriwatknp
Copy link
Member Author

Did you update the Codesandboxes? I don't have a comment other than this.

Yes, I have updated the CodeSandboxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants