[docs] Fix double API page redirection #36743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
commented
Apr 1, 2023
| /base/api/use-option/ /base/react-select/hooks-api/#use-option 301 | ||
| /base/api/use-select/ /base/react-select/hooks-api/#use-select 301 | ||
| /base/api/use-slider/ /base/react-slider/hooks-api/#use-slider 301 | ||
| /base/api/use-snackbar/ /base/react-snackbar/hooks-api/#use-snackbar 301 |
There was a problem hiding this comment.
A side note: the previous URLs feel clearer, when sharing them with someone else.
There was a problem hiding this comment.
Agree, but the new urls are at least understandable and the overall DX feels better.
There was a problem hiding this comment.
@mnajdova I wonder if Nevermind, we probably want to keep API in the pathname, and props would be too narrow./props/ and /hooks/ could work better for the URL, e.g. https://ark-ui.com/docs/react/components/popover/props. It's shorter and maybe clearer.
Netlify deploy previewBundle size report |
github-actions
bot
added
the
PR: out-of-date
mnajdova
approved these changes
Apr 4, 2023
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
siriwatknp
reviewed
Apr 4, 2023
Comment on lines
+13
to
+14
| "themeDefaultProps": true, | ||
| "muiName": "JoyModalOverflow", |
There was a problem hiding this comment.
#36262 did not update with the latest master.
siriwatknp
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a double redirection from the existing API pages. https://deploy-preview-35938--material-ui.netlify.app/base/api/use-tabs-list/
It was introduced in #35938.