Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove redundant files and fix regression #36775

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Apr 4, 2023

Fixes from #35938.

  • Use PropertiesTable file instead of PropretiesTable. I don't know why this file (the typo one) was created, if both are same. This in turn fixes regression where [docs] Hide the default API column if it's empty #36715 was not being applied.
  • The ApiPage component from the HookApiPage.js is no longer needed. So, removed the component and moved getTranslatedHeader method in MarkdownDocsV2 file.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation regression A bug, but worse scope: docs-infra Specific to the docs-infra product core Infrastructure work going on behind the scenes labels Apr 4, 2023
@mui-bot
Copy link

mui-bot commented Apr 4, 2023

Netlify deploy preview

https://deploy-preview-36775--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 371e2a1

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review April 4, 2023 10:26
@ZeeshanTamboli ZeeshanTamboli requested a review from a team April 4, 2023 10:33
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup @ZeeshanTamboli thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit fda2bc0 into mui:master Apr 4, 2023
8 of 9 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the docs-remove-unused-files branch April 4, 2023 12:19
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Apr 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants