[docs] Fix 404 links #36969
Merged
[docs] Fix 404 links #36969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy preview
Bundle size report |
| @@ -4,7 +4,7 @@ import createStack from './createStack'; | |||
| * | |||
| * Demos: | |||
| * | |||
| * - [Stack (Joy UI)](https://mui.com/joy/react-stack/) | |||
| * - [Stack (Joy UI)](https://mui.com/joy-ui/react-stack/) | |||
Comment on lines
+13
to
+15
| * TODO: this should really be fixed in findPagesMarkdown(). | ||
| * Plus replaceComponentLinks() shouldn't exist in the first place, | ||
| * the markdown folder location should match the URLs. |
There was a problem hiding this comment.
The logic that converts docs markdown file location to URL location is a mess right now. One step toward making it straightforward.
| @@ -211,8 +211,7 @@ async function run(argv: yargs.ArgumentsCamelCase<CommandOptions>) { | |||
| // Box's demo isn't ready | |||
| // Container's demo isn't ready | |||
| // Grid has problem with react-docgen | |||
| // Stack has problem with react-docgen | |||
| component.filename.match(/(Box|Container|ColorInversion|Grid|Stack)/)) || | |||
| component.filename.match(/(Box|Container|ColorInversion|Grid)/)) || | |||
There was a problem hiding this comment.
I fixed the Stack generation in #36785 but forgot to enable its page generation. It's why it's a 404: https://mui.com/joy-ui/api/stack/.
Comment on lines
-48
to
-54
| const replaceStylesLinks = (markdown: string) => { | ||
| return markdown.replace(/\(\/styles\/([^)]*)\)/gm, '(/system/styles/$1)'); | ||
| }; | ||
|
|
||
| export default function replaceMarkdownLinks(markdown: string) { | ||
| return replaceStylesLinks(replaceMaterialLinks(replaceAPILinks(replaceComponentLinks(markdown)))); | ||
| } |
There was a problem hiding this comment.
Dead code, only used in the tests.
| @@ -5,7 +5,7 @@ export default function DivButton() { | |||
| return ( | |||
| <Button | |||
| component="a" | |||
| href="https://mui.com/about-us/" | |||
| href="https://mui.com/about/" | |||
There was a problem hiding this comment.
Issue from #34990. 404 link
| /api/no-ssr/ /base/api/no-ssr/ 301 | ||
| /pt/api/no-ssr/ /pt/base/api/no-ssr/ 301 | ||
| /zh/api/no-ssr/ /zh/base/api/no-ssr/ 301 | ||
| /api/no-ssr/ /base/react-no-ssr/components-api/#no-ssr 301 |
There was a problem hiding this comment.
More double redirection from #36833.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues reported in https://app.ahrefs.com/site-audit/3524616/61/issues.
However, there are still some left, regressions from #35938, e.g.