Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[core] Remove outdated babel proposal plugins (#36795)" #37331

Merged
merged 1 commit into from May 19, 2023

Conversation

michaldudak
Copy link
Member

This reverts #36795

Without the removed plugins, the code was not transpiled correctly for Safari 12.5, which we still support. We will update the supported browsers list with the next major release. Then, we'll be able to revisit that PR.

@michaldudak michaldudak added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels May 19, 2023
@michaldudak michaldudak requested a review from a team May 19, 2023 08:39
@mui-bot
Copy link

mui-bot commented May 19, 2023

Netlify deploy preview

https://deploy-preview-37331--material-ui.netlify.app/

@material-ui/core: parsed: +3.78% , gzip: +3.83%
@material-ui/lab: parsed: +2.94% , gzip: +3.03%
@material-ui/system: parsed: +1.39% , gzip: +1.23%
@material-ui/unstyled: parsed: +3.20% , gzip: +2.57%
@mui/material-next: parsed: +1.85% , gzip: +1.89%
@mui/joy: parsed: +2.76% , gzip: +2.75%

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against bb42577

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's revert. I added it to the v6 milestone and in #30660.

I'm curious as to how may users still use Safari 12.5 on iOS. Perhaps it can be checked in Google Analytics if we are tracking it.

@michaldudak
Copy link
Member Author

According to browserslist it's 0.62% globally (https://browsersl.ist/#q=ios_saf+%3C%3D+12.5), but we can't change support between majors.

@michaldudak michaldudak merged commit 092b06a into mui:master May 19, 2023
20 checks passed
@michaldudak michaldudak deleted the revert-babel-plugins-removal branch May 19, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants