Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove todo link from sidebar #37373

Merged
merged 1 commit into from
May 24, 2023
Merged

[docs] Remove todo link from sidebar #37373

merged 1 commit into from
May 24, 2023

Conversation

brijeshb42
Copy link
Contributor

PR for CssVarsProvider documentation separately

@brijeshb42 brijeshb42 added the website Pages that are not documentation-related, marketing-focused. label May 23, 2023
@mui-bot
Copy link

mui-bot commented May 23, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37373--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 0455225

@mnajdova mnajdova changed the title [website]: Remove todo link from sidebar [docs] Remove todo link from sidebar May 23, 2023
@mnajdova mnajdova added docs Improvements or additions to the documentation and removed website Pages that are not documentation-related, marketing-focused. labels May 23, 2023
@brijeshb42 brijeshb42 requested a review from mnajdova May 23, 2023 10:40
@oliviertassinari
Copy link
Member

oliviertassinari commented May 23, 2023 •
edited

I think that it would be great to copy what was great about the older page into the new ones. I believe that are 2 things: #35213 (comment).

@brijeshb42
Copy link
Contributor Author

brijeshb42 commented May 23, 2023 •
edited

That was the idea but to move the docs for CssVarsProvider to mui-system docs instead of in material. That would be part of a separate PR as I need to modify the docs a little bit to refer to the system package. This PR was just to quickly remove the todo page.

@mnajdova

@mnajdova
Copy link
Member

That was the idea but to move the docs for CssVarsProvider to mui-system docs instead of in material. That would be part of a separate PR as I need to modify the docs a little bit to refer to the system package. This PR was just to quickly remove the todo page.

I am ok with including the changes linked in Olivier's PR in the next PR.

@mnajdova
Copy link
Member

Note, we will still need the pages in the Material UI docs, for people not familiar too much with how the @mui/system is related it could be great to have the content in the docs where they browser most of the features.

mnajdova
mnajdova approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brijeshb42 brijeshb42 merged commit bcf20bc into mui:master May 24, 2023
18 checks passed
@brijeshb42 brijeshb42 deleted the website-remove-todo-link branch May 25, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brijeshb42 @mui-bot @oliviertassinari @mnajdova