Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Base] Remove usage of component prop in docs #37462

Merged
merged 2 commits into from Jun 3, 2023

Conversation

@sai6855 sai6855 added docs Improvements or additions to the documentation component: tabs This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Jun 1, 2023
@mui-bot
Copy link

mui-bot commented Jun 1, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 7b6826b

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please remove this component section from the Usage page? I noticed it while reviewing #37463.

@sai6855
Copy link
Contributor Author

sai6855 commented Jun 2, 2023

@ZeeshanTamboli done with the change

@ZeeshanTamboli ZeeshanTamboli changed the title [Tabs][Base] Remove usage of component prop in docs [docs][Base] Remove usage of component prop in docs Jun 3, 2023
@ZeeshanTamboli ZeeshanTamboli removed the component: tabs This is the name of the generic UI component, not the React module! label Jun 3, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ZeeshanTamboli ZeeshanTamboli merged commit f511b89 into mui:master Jun 3, 2023
19 checks passed
@sai6855 sai6855 deleted the remove-tabs-usage branch June 3, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants