[Typography] Improve inherit variant logic #38123

ZeeshanTamboli · 2023-07-23T12:35:04Z

I have followed (at least) the PR section of the contributing guide.

Act on #33621 (comment) to fix #32942

Removes inherit from theme's typography and checks on the Typography component level.

CodeSandbox - https://codesandbox.io/s/blissful-wright-ptzjz3?file=/src/Demo.tsx

mui-bot · 2023-07-23T12:38:03Z

Netlify deploy preview

https://deploy-preview-38123--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 1546eb9

oliviertassinari

We probably don't need a test, but I think a comment would be great

packages/mui-material/src/Typography/Typography.js

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>

oliviertassinari · 2023-07-23T15:02:43Z

Proposed the same fix in #38124

mnajdova

The changes in the component makes sense, I am not 100% convinced about the theme changes. They are breaking after all, and I remember we had issues around this not long ago. We can try to merge, but be ready that we may revert if we see too many complains.

ZeeshanTamboli · 2023-07-28T10:29:16Z

Okay, let's do it in v6. I added this in #30660 to keep track.

oliviertassinari · 2023-07-28T11:47:31Z

Okay, let's do it in v6.

@ZeeshanTamboli This feels overly cautious, but no objections.

In this case, I think that we should still move forward with the bulk of the changes however, deprecating the variant instead of removing it. The goal is to control the leak, to not have the problem grow, but decrease over time.

packages/mui-material/src/styles/createTypography.d.ts

ZeeshanTamboli · 2023-07-28T16:56:19Z

In this case, I think that we should still move forward with the bulk of the changes however, deprecating the variant instead of removing it.

@oliviertassinari I pushed few changes. Please take a look.

packages/mui-material/src/styles/createTypography.d.ts

packages/mui-material/src/styles/createTypography.spec.ts

packages/mui-material/src/styles/createTypography.js

packages/mui-material/src/Typography/Typography.d.ts

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>

packages/mui-material/src/Typography/typography.spec.tsx

oliviertassinari

This looks ideal 👌

oliviertassinari · 2023-08-03T16:15:45Z

@ZeeshanTamboli Thanks for the follow-up, much appreciated, and much better.

Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

ZeeshanTamboli added 2 commits July 23, 2023 17:20

remove logic from theme typography

d582164

prettier

3f534b5

ZeeshanTamboli added component: Typography The React component. package: material-ui Specific to @mui/material customization: theme Centered around the theming features enhancement This is not a bug, nor a new feature labels Jul 23, 2023

fix ownerState.variant

3b17f25

ZeeshanTamboli marked this pull request as ready for review July 23, 2023 13:16

ZeeshanTamboli requested review from mnajdova and oliviertassinari July 23, 2023 13:44

oliviertassinari reviewed Jul 23, 2023

View reviewed changes

packages/mui-material/src/Typography/Typography.js Show resolved Hide resolved

Update packages/mui-material/src/Typography/Typography.js

0e50e0d

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>

ZeeshanTamboli requested a review from oliviertassinari July 23, 2023 14:20

oliviertassinari mentioned this pull request Jul 23, 2023

[Link][joy-ui] Fix font inherit #38124

Merged

oliviertassinari removed the customization: theme Centered around the theming features label Jul 23, 2023

sai6855 mentioned this pull request Jul 24, 2023

[Material][Menu] Add Nested Menu demo #37570

Draft

1 task

mnajdova reviewed Jul 24, 2023

View reviewed changes

ZeeshanTamboli mentioned this pull request Jul 28, 2023

[discussion] Preparing v6 #30660

Open

2 tasks

ZeeshanTamboli added v6.x breaking change labels Jul 28, 2023

oliviertassinari removed breaking change v6.x labels Jul 28, 2023

ZeeshanTamboli added 4 commits July 28, 2023 19:11

revert theme typography changes, add TODO

74e14c6

fix types

04af05a

add type tests

729ee07

Merge branch 'master' into improve-typograhy-variant-inherit-logic

19c4540

update test

896a1e8

ZeeshanTamboli commented Jul 28, 2023

View reviewed changes

packages/mui-material/src/styles/createTypography.d.ts Outdated Show resolved Hide resolved

ZeeshanTamboli requested a review from mnajdova July 28, 2023 16:56

ZeeshanTamboli mentioned this pull request Jul 28, 2023

[core] Remove unnecessary Required utility type from Typography font style type #38203

Merged

1 task

oliviertassinari reviewed Jul 28, 2023

View reviewed changes

typo

dbc8315

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>

oliviertassinari reviewed Jul 28, 2023

View reviewed changes

packages/mui-material/src/Typography/typography.spec.tsx Outdated Show resolved Hide resolved

oliviertassinari and others added 3 commits July 28, 2023 19:25

to remove at one point

6f0fee9

to remove at one point

c56c8a4

revert changes

79abb09

ZeeshanTamboli requested a review from oliviertassinari July 29, 2023 06:36

oliviertassinari reviewed Jul 29, 2023

View reviewed changes

oliviertassinari approved these changes Aug 2, 2023

View reviewed changes

Merge branch 'master' into improve-typograhy-variant-inherit-logic

e431f50

ZeeshanTamboli mentioned this pull request Aug 3, 2023

[docs] Update API docs for Number Input component #38301

Merged

1 task

Merge branch 'master' into improve-typograhy-variant-inherit-logic

1546eb9

ZeeshanTamboli merged commit 6cd17b8 into mui:master Aug 3, 2023
18 checks passed

ZeeshanTamboli deleted the improve-typograhy-variant-inherit-logic branch August 3, 2023 14:08

oliviertassinari mentioned this pull request Aug 20, 2023

[Typography] Apply font properties to typography inherit variant #33621

Merged

1 task

kealjones-wk mentioned this pull request Feb 28, 2024

[material-ui][Typography] Fix Typography inherit variant styles #41308

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Typography] Improve inherit variant logic #38123

[Typography] Improve inherit variant logic #38123

ZeeshanTamboli commented Jul 23, 2023 •

edited

mui-bot commented Jul 23, 2023 •

edited

oliviertassinari left a comment

oliviertassinari commented Jul 23, 2023

mnajdova left a comment

ZeeshanTamboli commented Jul 28, 2023

oliviertassinari commented Jul 28, 2023 •

edited

ZeeshanTamboli commented Jul 28, 2023

oliviertassinari left a comment

oliviertassinari commented Aug 3, 2023 •

edited

[Typography] Improve inherit variant logic #38123

[Typography] Improve inherit variant logic #38123

Conversation

ZeeshanTamboli commented Jul 23, 2023 • edited

mui-bot commented Jul 23, 2023 • edited

Netlify deploy preview

Bundle size report

oliviertassinari left a comment

Choose a reason for hiding this comment

oliviertassinari commented Jul 23, 2023

mnajdova left a comment

Choose a reason for hiding this comment

ZeeshanTamboli commented Jul 28, 2023

oliviertassinari commented Jul 28, 2023 • edited

ZeeshanTamboli commented Jul 28, 2023

oliviertassinari left a comment

Choose a reason for hiding this comment

oliviertassinari commented Aug 3, 2023 • edited

ZeeshanTamboli commented Jul 23, 2023 •

edited

mui-bot commented Jul 23, 2023 •

edited

oliviertassinari commented Jul 28, 2023 •

edited

oliviertassinari commented Aug 3, 2023 •

edited