Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][SpeedDial] Fix the tooltip title placement when speed dial directions selected is left | right. #41414

Closed
wants to merge 4 commits into from

Conversation

ashr81
Copy link

@ashr81 ashr81 commented Mar 9, 2024

Fixes #41067

Before:

Screenshot 2024-03-09 at 3 27 01 PM

After:

Screenshot 2024-03-09 at 3 27 21 PM

@mui-bot
Copy link

mui-bot commented Mar 9, 2024

Netlify deploy preview

https://deploy-preview-41414--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against b53bfb7

@danilo-leal danilo-leal added component: tooltip This is the name of the generic UI component, not the React module! component: speed dial This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Mar 9, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should address handling for other tooltip placements too. I'm uncertain about the necessity of transformOrigin and why it was initially included for left and right tooltip placements.

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Mar 11, 2024

We should consider using the tooltip here instead of SpeedDialActionStaticTooltip, which is a span component. By using the tooltip, we can directly provide the tooltipPlacement prop to the tooltip placement which will handle the transformations.

@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Mar 11, 2024
@DiegoAndai
Copy link
Member

Hey @ashr81, thanks for working on this!

We're releasing the last v5 version next week (except for urgent fixes), after which we'll start working on the next branch and release v6 alpha versions. Because of this, we're only merging critical PRs this week and will move all others to the next branch when that's created.

As @ZeeshanTamboli pointed to further improvements, we'll also move this PR to point to the next branch next week so we can keep working on it. I'll take care of re-pointing it correctly.

Feel free to let me know if I can help with anything.

@DiegoAndai DiegoAndai self-assigned this Mar 15, 2024
@ashr81 ashr81 changed the base branch from master to next April 9, 2024 16:59
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 6, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 19, 2024
@ashr81 ashr81 marked this pull request as draft May 19, 2024 11:07
@ashr81
Copy link
Author

ashr81 commented May 20, 2024

Closing this PR since the fix is already included in this PR: #41997.

@ashr81 ashr81 closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][SpeedDial] Bug with right/left direction in persistent action tooltips
5 participants