[code-infra] Allow to customize what is considered as a component file #41950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41950--material-ui.netlify.app/ Bundle size report |
|
Let's test the new regex in our repos and see if it works. I don't think a config option is necessary in this case. It will only add noise. |
|
Ok, I created #42004 for that. on MUI-X it does not create an issue, and I don't think toolpad uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized my components
ChartsXAxisandChartsYAxiswas not considered as component because they have two capital letters one after the other.A solution could be to do the following update on the regexp, but not sure every body would like it, so I'm adding a setting option