Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][CircularProgress] Deprecate composed classes #42076

Merged
merged 10 commits into from May 8, 2024
Merged

[material-ui][CircularProgress] Deprecate composed classes #42076

merged 10 commits into from May 8, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 1, 2024

part of #41282

@sai6855 sai6855 added docs Improvements or additions to the documentation component: CircularProgress The React component deprecation New deprecation message package: material-ui Specific to @mui/material labels May 1, 2024
@mui-bot
Copy link

mui-bot commented May 1, 2024 •
edited

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 860db31

@sai6855 sai6855 marked this pull request as draft May 1, 2024 06:23
@sai6855 sai6855 marked this pull request as ready for review May 1, 2024 07:59
@sai6855 sai6855 requested a review from DiegoAndai May 1, 2024 11:56
@DiegoAndai DiegoAndai mentioned this pull request May 2, 2024
Open
30 tasks
DiegoAndai
DiegoAndai reviewed May 3, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @sai6855!

A couple of comments:

packages/mui-codemod/src/deprecations/circular-progress-classes/postcss-plugin.js Outdated Show resolved Hide resolved
packages/mui-codemod/src/deprecations/circular-progress-classes/test-cases/expected.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 3, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 6, 2024
@sai6855 sai6855 changed the title [material-ui][CircularProgress] Deprectae composed classes [material-ui][CircularProgress] Deprecate composed classes May 6, 2024
@DiegoAndai DiegoAndai merged commit 2f61ff7 into mui:next May 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: CircularProgress The React component deprecation New deprecation message docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sai6855 @mui-bot @DiegoAndai