Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod][Divider] Only apply codemod if light prop is present #42098

Merged
merged 2 commits into from May 8, 2024

Conversation

DiegoAndai
Copy link
Member

Opacity 0.6 was always being applied, but it should apply the opacity only if a light prop is present.

@DiegoAndai DiegoAndai added component: divider This is the name of the generic UI component, not the React module! package: codemod Specific to @mui/codemod labels May 2, 2024
@DiegoAndai DiegoAndai self-assigned this May 2, 2024
@mui-bot
Copy link

mui-bot commented May 2, 2024

Netlify deploy preview

https://deploy-preview-42098--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e1096b1

Copy link
Contributor

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiegoAndai DiegoAndai merged commit 3efb7d1 into mui:next May 8, 2024
19 checks passed
@DiegoAndai DiegoAndai deleted the divider-light-prop-fix branch May 8, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: divider This is the name of the generic UI component, not the React module! package: codemod Specific to @mui/codemod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants