[website] Update MUI X deps and migrate TreeView demos to v7 API #42149
Conversation
noraleonte
added
the
website
noraleonte
requested review from
flaviendelangle,
mnajdova,
LukasTy and
danilo-leal
Netlify deploy previewhttps://deploy-preview-42149--material-ui.netlify.app/ Bundle size report |
docs/package.json
Outdated
| "@mui/x-date-pickers": "6.19.9", | ||
| "@mui/x-date-pickers-pro": "6.19.9", | ||
| "@mui/x-date-pickers": "7.3.2", | ||
| "@mui/x-date-pickers-pro": "7.3.2", | ||
| "@mui/x-license-pro": "6.10.2", |
There was a problem hiding this comment.
Consider removing it.
The package does not seem to be used anywhere explicitly and has already been renamed to @mui/x-license.
It is a direct dependency of the paid packages and if there are no direct references to it in the project, I don't see a reason to have it explicitly listed. 🙈
| "@mui/x-license-pro": "6.10.2", |
There was a problem hiding this comment.
We have
import { LicenseInfo } from '@mui/x-data-grid-pro';
Which IMHO is a bad pattern now that we use the license key for several X commercial packages
I would prefer to install @mui/x-license and set the license from it instead of setting from the grid (which is deprecated in #11956)
There was a problem hiding this comment.
Great point. 👌
However, IMHO, this could also be a separate PR as well, because it does not seem directly related to what is being done here. 🤔
There was a problem hiding this comment.
Yep, but removing the package is not related to this PR either 😆
There was a problem hiding this comment.
Re-requesting reviews just to make sure I didn't mess something up 🙈
There was a problem hiding this comment.
Out of scope of this PR: Is it just me or does this demo really need a fix for overflow scrolling? 🤔
In its current form it feels somewhat broken when part of the tree view is hidden when it could be scrollable. 🙈 🤷
Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
@danilo-leal I cleaned up the spacing of both demos a little bit. Should be closer to the initial versions 🤔 Let me know what you think :) |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
In this PR
https://deploy-preview-42149--material-ui.netlify.app/x