New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Create examples eslint rule #42170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
eslint-examples
branch
from
May 9, 2024 00:40
1ace716
to
bc57eb2
Compare
oliviertassinari
force-pushed
the
eslint-examples
branch
from
May 9, 2024 00:41
bc57eb2
to
3c6625c
Compare
Netlify deploy previewhttps://deploy-preview-42170--material-ui.netlify.app/ Bundle size report |
michaldudak
approved these changes
May 10, 2024
oliviertassinari
force-pushed
the
eslint-examples
branch
from
May 21, 2024 14:29
56df305
to
9d735be
Compare
@@ -473,5 +473,36 @@ module.exports = { | |||
'import/prefer-default-export': 'off', | |||
}, | |||
}, | |||
{ | |||
/** | |||
* Examples are for demonstration purposes and should not be considered a part of the library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Janpot we will be able to remove https://github.com/mui/mui-toolpad/blob/282d1b72b789048df6a98d2a2a6e48c4b77a0bd9/.eslintrc.js#L115
oliviertassinari
changed the title
[code-infra] Create examples rule
[code-infra] Create examples eslint rule
May 21, 2024
Janpot
reviewed
May 21, 2024
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help a bit with #42031 by removing one of the
.eslintrc.js
files that aren't on the root. Also, will help with https://github.com/mui/mui-toolpad/blob/d0e2bd5dd2bf64b74bd4d0d235c5538aebaaa35b/.eslintrc.js#L108.