New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Tigthen up the header design #42180
[docs-infra] Tigthen up the header design #42180
Conversation
Netlify deploy previewhttps://deploy-preview-42180--material-ui.netlify.app/ Bundle size report |
@danilo-leal Had a peek 👀. I've got some notes, I didn't mean for it to be this long, but it's mostly multiple points talking about the same small details.
Screenshot of the suggested changes attached: |
Oh also, I forgot to mention the header's background blur. Was that removed in this PR? I don't see it in the changes. I thought that was a kinda cool vibe |
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@colmtuite Okay, most of the things have been tackled already! Quick thoughts on some of them, though:
PS: I still couldn't figure out why the version button don't have the icon animation and the product switcher button has... even though the color is different, that CSS is defined at the size level, and they have the same size. Dunno 🤷. Will probably fix that later to merge this one faster. |
This also includes the website header! The main purpose of the changes below is to carve a few height pixels out and fine-tune spacing and sizing a bit. Here's a summary:
--MuiDocs-header-height
var size from 64px to 57px