[core] Fix scroll restoration in the docs #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/package.json
Outdated
| @@ -61,7 +61,7 @@ | |||
| "lz-string": "^1.4.4", | |||
| "markdown-to-jsx": "^7.1.7", | |||
| "marked": "^4.0.17", | |||
| "next": "12.2.0", | |||
| "next": "^12.2.5", | |||
There was a problem hiding this comment.
We have two different Next.js app (one for the docs, one for toolpad), I'm keeping this one in sync with the docs-infra not toolpad. I think that it's beneficial to have two different Next.js versions to make sure they are decoupled.
There was a problem hiding this comment.
Perhaps we should decouple @mui/monorepo as well?
oliviertassinari
added
core
|
I have found an issue with this approach, it leads to a warning on the core's side. We need to change the import a bit. |
1 task
1 task
github-actions
bot
added
the
PR: out-of-date
Janpot
reviewed
Sep 6, 2022
oliviertassinari
force-pushed
the
update-mono-repo
branch
from
33a51d9
to
7b1b8d9
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
update-mono-repo
branch
2 times, most recently
from
41d898d
to
f7f1362
Compare
oliviertassinari
force-pushed
the
update-mono-repo
branch
from
f7f1362
to
b646e6f
Compare
Janpot
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-866--mui-toolpad-docs.netlify.app/toolpad/getting-started/overview/