Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug template: Move reproduction above current behavior #908

Merged
merged 2 commits into from Oct 20, 2022
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 6, 2022

Doesn't this logically belong before "current behavior"? I mean, how can I explain the current behavior without first explaining how to produce the behavior?
I repeatedly find myself explaining the problem in "current behavior" and then arriving at "reproduction steps" and realizing I already gave them in the earlier section.

@render
Copy link

render bot commented Sep 6, 2022

@oliviertassinari oliviertassinari requested a deployment to bug-template - toolpad-db PR #908 September 6, 2022 13:23 — with Render Abandoned
@apedroferreira
Copy link
Member

not sure, maybe it makes sense to first explain the issue in general and then provide the reproduction as it can be more specific

@oliviertassinari
Copy link
Member

This PR makes me think of mui/mui-design-kits#73 (comment)

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 9, 2022

One pain point I have with the current bug template is the duplication of the effort between "Actual behavior" and "Reproduction". Most of the time, I almost give the full reproduction on the "Actual behavior" step. It seems to be close to the pain point raised by @Janpot

I repeatedly find myself explaining the problem in "current behavior" and then arriving at "reproduction steps" and realizing I already gave them in the earlier section.

So I think that it could make sense to ask for the reproduction directly inside the "Actual behavior", or just after. I would only be careful with the change not reducing the compliance rate of the developers with the instructions.

Otherwise, I personally think that this is a change that should be first experimented with http://github.com/mui/material-ui as we will learn faster about whether it's better or worse.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it could indeed work better

@Janpot
Copy link
Member Author

Janpot commented Sep 11, 2022

Otherwise, I personally think that this is a change that should be first experimented with http://github.com/mui/material-ui as we will learn faster about whether it's better or worse.

👍 opening mui/material-ui#34279

@oliviertassinari
Copy link
Member

I suspect that we could move forward with this change 👍

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 19, 2022
@render
Copy link

render bot commented Oct 19, 2022

@Janpot Janpot enabled auto-merge (squash) October 19, 2022 14:04
@Janpot Janpot merged commit e5be280 into master Oct 20, 2022
@Janpot Janpot deleted the bug-template branch October 20, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants