[code-infra] Use the @mui/internal-markdown package #12188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12188--material-ui-x.netlify.app/ |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
michaldudak
force-pushed
the
core-integration/41240
branch
from
b362239
to
e32b7b8
Compare
github-actions
bot
removed
the
PR: out-of-date
michaldudak
force-pushed
the
core-integration/41240
branch
from
f6ed9e8
to
e32b7b8
Compare
|
The failing builds seem not to be related to my changes. @mui/x, are they "expected" (based on other changes you've done since the last monorepo update)? |
Janpot
approved these changes
Feb 27, 2024
@michaldudak It seems to be related to this modification in core. https://github.com/mui/material-ui/pull/39137/files#r1501919356 I'm trying the fix here #12105 |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 task
|
Done in #12105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the @mui/internal-markdown package from npm instead of the monorepo.
Renamed all the references from @mui/markdown to @mui/internal-markdown.
Uses changes from mui/material-ui#41240.
This bumps the Core monorepo reference to the latest master. I also had to update the Core packages the make the build pass.