Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add accessibility page to TreeView docs #12845

Merged
merged 7 commits into from May 3, 2024

Conversation

noraleonte
Copy link
Contributor

Closes #12435

@noraleonte noraleonte added docs Improvements or additions to the documentation component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 19, 2024
@noraleonte noraleonte self-assigned this Apr 19, 2024
@mui-bot
Copy link

mui-bot commented Apr 19, 2024

@flaviendelangle
Copy link
Member

Small benchmark I found: https://dgreene1.github.io/react-accessible-treeview/docs/api

@flaviendelangle
Copy link
Member

I personally find the table used in https://deploy-preview-12845--material-ui-x.netlify.app/x/react-data-grid/accessibility/ more readable that plain text.
Is there something that prevents us from using a similar approach?

@noraleonte
Copy link
Contributor Author

Is there something that prevents us from using a similar approach?

Not really 🤔 Let's try the table and see how it looks 👌

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition! 👏

docs/data/tree-view/accessibility/accessibility.md Outdated Show resolved Hide resolved
docs/data/tree-view/accessibility/accessibility.md Outdated Show resolved Hide resolved
docs/data/tree-view/accessibility/accessibility.md Outdated Show resolved Hide resolved
docs/data/tree-view/accessibility/accessibility.md Outdated Show resolved Hide resolved
docs/data/tree-view/accessibility/accessibility.md Outdated Show resolved Hide resolved
docs/data/tree-view/accessibility/accessibility.md Outdated Show resolved Hide resolved
noraleonte and others added 5 commits April 26, 2024 12:07
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
@noraleonte noraleonte requested a review from LukasTy May 3, 2024 10:05
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice result! 👏

@LukasTy LukasTy added the accessibility a11y label May 3, 2024
@noraleonte noraleonte merged commit b5a8fda into mui:master May 3, 2024
18 checks passed
@noraleonte noraleonte deleted the accessibility-page branch May 3, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][Tree View] Add a11y/keyboard navigation documentation
4 participants