Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Fix props propagation and theme entry in TreeItem2 #12889

Merged
merged 2 commits into from May 7, 2024

Conversation

flaviendelangle
Copy link
Member

No description provided.

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 24, 2024
...extractEventHandlers(parameters),
...extractEventHandlers(externalProps),
};
const externalEventHandlers = extractEventHandlers(externalProps);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the root props should get the event handlers passed from parameters

@mui-bot
Copy link

mui-bot commented Apr 24, 2024

Deploy preview: https://deploy-preview-12889--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b6b8b5d

@flaviendelangle flaviendelangle marked this pull request as ready for review April 24, 2024 06:41
@flaviendelangle flaviendelangle self-assigned this Apr 24, 2024
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🎉

@flaviendelangle flaviendelangle merged commit 3588698 into mui:master May 7, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the fix-tree-item-2-errors branch May 7, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants