[DataGrid] Change isCellEditable params type #12896
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12896--material-ui-x.netlify.app/ |
atomheartother
changed the title
zannager
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi MUI-X team, thanks for your hard work.
I believe I have come across an incorrect type for
isCellEditable'sparams, see the diff.The bug
As the types currently are on master (and in production) ,
params.rowisany, meaning any typo or wrong property onparams.rowwon't be picked up by TS, despite users' efforts to type their grid strongly:This also means
params.valueis, I believe, incorrectly typed, making it look like the value has the row's type (which it shouldn't):The fix
With my fairly simple MR, Typescript understands what's happening and warns the user against potential bug:
That's pretty much it.