[DataGrid] Fix background colors when CSSVarsProvider is used
#12901
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
bug 🐛
|
Deploy preview: https://deploy-preview-12901--material-ui-x.netlify.app/ |
romgrk
reviewed
Apr 25, 2024
|
|
||
| const removeOpacity = (color: string) => `rgb(from ${color} r g b / 1)`; | ||
| function blendCssVars(background: string, overlay: string, opacity: number) { | ||
| return `color-mix(in srgb,${background}, ${removeOpacity(overlay)} calc(${opacity} * 100%))`; |
There was a problem hiding this comment.
Wasn't sure if we could use color-mix. What are our supported browser versions?
There was a problem hiding this comment.
I wanted to validate this approach.
color-mix requires iOS >= 16.2, while we currently support >= 15.4. Same for Safari on MacOS. Other browsers seem to match what we have in our browserslist.
Do you have other ideas for solving this issue?
There was a problem hiding this comment.
No, this is the only thing that could work with CSS variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12855