[DataGrid] Pass reason to onPaginationModelChange
#12923
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12923--material-ui-x.netlify.app/ |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
zannager
added
the
component: data grid
packages/x-data-grid-premium/src/hooks/features/aggregation/gridAggregationInterfaces.ts
Outdated
Show resolved
Hide resolved
| ), | ||
| }, | ||
| }), | ||
| 'setPaginationModel', |
There was a problem hiding this comment.
Could you also pass the "stateRestorePreProcessing" reason in the stateRestorePreProcessing function?
There was a problem hiding this comment.
I'll take a look at this as soon as possible, thank you
cherniavskii
changed the title
onPaginationModelChange
cherniavskii
added
regression
file: [packages\x-data-grid\src\hooks\features\pagination\useGridPaginationModel.ts] (+) updated setPaginationModel api.current.setState to set the reason, 'setPaginationModel'. this was removed in commit 7c4ba74.
cherniavskii
force-pushed
the
bugfix/12897
branch
from
6373509
to
12ce10c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12897