Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix scroll restoration in the docs #5938

Merged
merged 3 commits into from
Sep 19, 2022
Merged

[core] Fix scroll restoration in the docs #5938

merged 3 commits into from
Sep 19, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 28, 2022 •
edited

https://deploy-preview-5938--material-ui-x.netlify.app/x/introduction/

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Aug 28, 2022
@mui-bot
Copy link

mui-bot commented Aug 28, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 482.2 730.4 705.9 630.18 106.409
Sort 100k rows ms 533.4 1,066 801.3 831.56 174.981
Select 100k rows ms 192.2 348.6 233.2 250.76 54.29
Deselect 100k rows ms 124.6 211.5 193.9 180.8 32.269

Generated by 🚫 dangerJS against a9ee765

@oliviertassinari oliviertassinari requested a review from a team August 28, 2022 10:17
@oliviertassinari
Copy link
Member Author

I have found an issue with this approach, it leads to a warning on the core's side. We need to change the import a bit.

@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait label Aug 29, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 30, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@oliviertassinari oliviertassinari changed the base branch from master to next September 9, 2022 16:02
@oliviertassinari oliviertassinari mentioned this pull request Sep 11, 2022
Merged
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 17, 2022
@oliviertassinari oliviertassinari force-pushed the update-mono-repo branch 2 times, most recently from 22f12b8 to 0d204c9 Compare September 17, 2022 15:39
@oliviertassinari oliviertassinari removed the on hold There is a blocker, we need to wait label Sep 17, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2022
@oliviertassinari oliviertassinari merged commit c087f78 into mui:next Sep 19, 2022
@oliviertassinari oliviertassinari deleted the update-mono-repo branch September 19, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-bot @flaviendelangle