Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use components instead of demos for SelectorsDocs #6103

Merged
merged 8 commits into from Oct 5, 2022
Merged

[docs] Use components instead of demos for SelectorsDocs #6103

merged 8 commits into from Oct 5, 2022

Conversation

flaviendelangle
Copy link
Member

Follow up to mui/material-ui#34243

@flaviendelangle flaviendelangle added the docs Improvements or additions to the documentation label Sep 9, 2022
@flaviendelangle flaviendelangle self-assigned this Sep 9, 2022
@flaviendelangle flaviendelangle changed the title [docs] Use components instead of demos for SelectorsDocs [docs] Use components instead of demos for SelectorsDocs Sep 9, 2022
@flaviendelangle flaviendelangle mentioned this pull request Sep 9, 2022
Merged
4 tasks
@mui-bot
Copy link

mui-bot commented Sep 9, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 474 889.9 643.9 677.4 180.247
Sort 100k rows ms 553.7 1,133.7 701.8 795.16 190.808
Select 100k rows ms 158.7 389.4 269.5 259.92 77.303
Deselect 100k rows ms 154.8 266.8 190 195.3 38.254

Generated by 🚫 dangerJS against 1cad663

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 12, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 29, 2022
@flaviendelangle flaviendelangle marked this pull request as ready for review September 29, 2022 10:24
m4theushw
m4theushw approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the monorepo to the latest commit before merging.

docs/src/modules/components/ComponentLinkHeader.js
@@ -0,0 +1 @@
export { default } from 'docs/src/modules/components/ComponentLinkHeader';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have checked this PR before opening #6374. It took some time to figure out why this component couldn't be loaded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@flaviendelangle flaviendelangle mentioned this pull request Oct 5, 2022
Merged
@flaviendelangle flaviendelangle merged commit 742f4f7 into mui:next Oct 5, 2022
@flaviendelangle flaviendelangle deleted the docs-components branch October 5, 2022 10:15
cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Oct 20, 2022
@cherniavskii
add missing ComponentLinkHeader component
1569f9f 
see mui#6103
@cherniavskii cherniavskii mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@flaviendelangle flaviendelangle

Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flaviendelangle @mui-bot @m4theushw