Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Change reproduction position #6621

Merged

Conversation

oliviertassinari
Copy link
Member

We have tried the change mui/material-ui#34279 in core and toolpad, it seems to be a step forward, a proposal to do the same here.

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 24, 2022
@mui-bot
Copy link

mui-bot commented Oct 24, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6621--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 537.8 907.9 652 708.84 148.979
Sort 100k rows ms 568.1 1,105.1 568.1 878.56 195.352
Select 100k rows ms 230.1 363.1 297.4 293.04 45.588
Deselect 100k rows ms 113.8 279.9 210.1 207.04 57.64

Generated by 🚫 dangerJS against 3566da7

@oliviertassinari oliviertassinari removed the request for review from siriwatknp October 26, 2022 11:00
@oliviertassinari oliviertassinari merged commit 9e5d973 into mui:next Oct 29, 2022
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 29, 2022

We have used this in Core and Toolpad for a couple of weeks now, it seems to have gone smoothly. It's more enjoyable.

@oliviertassinari oliviertassinari deleted the issue-template-change-order branch October 29, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants