[DataGrid] Fix flickering on mount #7205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
component: data grid
2 tasks
These are the results for the performance tests:
|
fix failing tests
cherniavskii
force-pushed
the
fix-grid-flickering-next
branch
from
2e89604
to
403e99b
Compare
cherniavskii
commented
Dec 21, 2022
| @@ -1121,7 +1121,7 @@ describe('<DataGridPro /> - Row Editing', () => { | |||
| const cell = getCell(0, 2); | |||
| userEvent.mousePress(cell); | |||
| fireEvent.doubleClick(cell); | |||
| await act(() => { | |||
| await waitFor(() => { | |||
There was a problem hiding this comment.
I don't understand why, but without this change the test was failing with:
The current testing environment is not configured to support act
There was a problem hiding this comment.
I went through the call stack and found that the column headers are trying to react to a scroll event. Placing a breakpoint where scrollPositionChange is published I found that the custom edit component is calling .focus(). You can revert this change and do the following to make the test pass:
diff --git a/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx b/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx
index 34cf0badc..061277b03 100644
--- a/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx
+++ b/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx
@@ -27,7 +27,7 @@ describe('<DataGridPro /> - Row Editing', () => {
const ref = React.useRef<HTMLInputElement>(null);
React.useLayoutEffect(() => {
if (hasFocus) {
- ref.current!.focus();
+ ref.current!.focus({ preventScroll: true });
}
}, [hasFocus]);
return <input ref={ref} />;
cherniavskii
commented
Dec 21, 2022
| @@ -716,13 +716,13 @@ describe('<DataGrid /> - Keyboard', () => { | |||
| <DataGrid rows={rows} columns={columns} /> | |||
| </div>, | |||
| ); | |||
| expect(renderCell.callCount).to.equal(2); | |||
| expect(renderCell.callCount).to.equal(6); | |||
There was a problem hiding this comment.
And the number of rerenders changed here again 🤷🏻♂️
#7155 (comment)
m4theushw
approved these changes
Dec 22, 2022
| @@ -1121,7 +1121,7 @@ describe('<DataGridPro /> - Row Editing', () => { | |||
| const cell = getCell(0, 2); | |||
| userEvent.mousePress(cell); | |||
| fireEvent.doubleClick(cell); | |||
| await act(() => { | |||
| await waitFor(() => { | |||
There was a problem hiding this comment.
I went through the call stack and found that the column headers are trying to react to a scroll event. Placing a breakpoint where scrollPositionChange is published I found that the custom edit component is calling .focus(). You can revert this change and do the following to make the test pass:
diff --git a/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx b/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx
index 34cf0badc..061277b03 100644
--- a/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx
+++ b/packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx
@@ -27,7 +27,7 @@ describe('<DataGridPro /> - Row Editing', () => {
const ref = React.useRef<HTMLInputElement>(null);
React.useLayoutEffect(() => {
if (hasFocus) {
- ref.current!.focus();
+ ref.current!.focus({ preventScroll: true });
}
}, [hasFocus]);
return <input ref={ref} />;
2 tasks
oliviertassinari
added
design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #7155 to the
nextbranch