Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR changes. Why this is wanted. And, if needed, how it does it.
Git checklist:
CHANGELOG.md
under the[Unreleased]
header.This PR updates Electron from 6.x to 7.1.10 which should fix a number of issues including crash during the app termination.
Due to API changes in Electron some of the calls had to be changed, highlight mode on tray icon on macOS is no longer handled by Electron so there is no way to control it anymore, so I had to remove the call to
tray.setHightlightMode()
, but that doesn't look bad on macOS so it's fine that we let the system to highlight the item on click, the highlight does not stay when the window is open.Breaking changes document:
https://www.electronjs.org/docs/api/breaking-changes
Notable changes since v6:
See more: https://github.com/electron/electron/releases
This change is