Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to electron 7 #1416

Merged
merged 2 commits into from Jan 27, 2020
Merged

Update to electron 7 #1416

merged 2 commits into from Jan 27, 2020

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Jan 24, 2020

Describe what this PR changes. Why this is wanted. And, if needed, how it does it.

Git checklist:

This PR updates Electron from 6.x to 7.1.10 which should fix a number of issues including crash during the app termination.

Due to API changes in Electron some of the calls had to be changed, highlight mode on tray icon on macOS is no longer handled by Electron so there is no way to control it anymore, so I had to remove the call to tray.setHightlightMode(), but that doesn't look bad on macOS so it's fine that we let the system to highlight the item on click, the highlight does not stay when the window is open.

Breaking changes document:
https://www.electronjs.org/docs/api/breaking-changes

Notable changes since v6:

See more: https://github.com/electron/electron/releases


This change is Reviewable

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just make sure it's tested a little bit on all platforms before merged. :lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor Author

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faern could you please have a look on Linux?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@pronebird pronebird merged commit 64abc03 into master Jan 27, 2020
@pronebird pronebird deleted the update-to-electron-7 branch January 27, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants