-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time zone being ignored on Android #4809
Fix time zone being ignored on Android #4809
Conversation
DES-235 The time zone is ignored on Android
We use Slack discussion: https://mullvad.slack.com/archives/C33N9MLQ7/p1686144914485789 |
chrono
to 0.4.26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
8aca744
to
32fe78d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I sign the relevant commits and merge them?
Reviewed 6 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
32fe78d
to
8d90bb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to do so 😊
Reviewable status: complete! all files reviewed, all discussions resolved
8d90bb5
to
f7d84a7
Compare
Fix time zone being ignored on Android, incorrectly outputting UTC timestamps. This more recent version of `chrono` extracts timezone info from a tzdata file on Android. This issue is recognized in `chrono`'s issue tracker: chronotope/chrono#922
Since `chrono 0.4.23`, the use of `chrono::NaiveDateTime::from_timestamp` is deprecated in favor of `chrono::NaiveDateTime::from_timestamp_opt`, which returns an `Option` instead of panicking if number of seconds is out of range.
f7d84a7
to
7747e2e
Compare
Fix time zone being ignored on Android, incorrectly outputting UTC timestamps. A fix is included in
chrono >= 4.25
.This issue is recognized in
chrono
's issue tracker: chronotope/chrono#922, and the fix seems to be to extract timezone info from a tzdata file.This change is