net: consider /dns/localhost as private address #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/private-addr-dns
branch
from
6b6ff31
to
b87b418
Compare
marten-seemann
approved these changes
Sep 17, 2023
marten-seemann
changed the title
marten-seemann
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes IsPrivateAddr check to correctly classify localhost dns addresses as private.
This fixes sub domain check to correctly classify equal domains as sub domains. So /dns/localhost/ is classified as non public. This is similar to https://pkg.go.dev/github.com/miekg/dns#IsSubDomain. I didn't want to import a library for this so I'm using a custom implementation.