Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TLS permanent #215

Closed
wants to merge 2 commits into from
Closed

Make TLS permanent #215

wants to merge 2 commits into from

Conversation

carpawell
Copy link

There are multiformats/go-multiaddr#153 and multiformats/multiaddr#109 PR's that add TLS.

Also, TLS is used in examples in README in the main repo.

Therefore, it seems logical to make it permanent.

@rvagg
Copy link
Member

rvagg commented Jun 18, 2021

permanent - this codec has been widely adopted and may not reassigned.

I would say that while TLS is widely adopted itself, that use of the codec code here may not be - and you've linked to PRs, not merged and released code.

The fact that it's draft shouldn't be interpreted as it being at imminent risk of being removed, that's not the case at all. We've removed very few entries from the table and mostly that's happened immediately after merge when we realised it was a mistake. So it's more of a journey toward permanent, with the preference to not lock in entries where they aren't in heavy use - like dag-pb, for instance.

So I'm -1 on this for now, but it's certainly a good candidate for permanent if we see this code being widely used.

@carpawell
Copy link
Author

So it is ok, if draft != can be deleted. My only misunderstanding was about using it as an example in the main repo and also that TLS is certainly a wildly used protocol, but somehow it is "draft".

BTW, both PRs that I linked were merged.

@Stebalien
Copy link
Member

My only misunderstanding was about using it as an example in the main repo and also that TLS is certainly a wildly used protocol, but somehow it is "draft".

TLS is widely used. The TLS multicodec is not.

@carpawell carpawell closed this by deleting the head repository Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants